Re: [PATCH 12/19] remote-curl: avoid assigning string constant to non-const variable

> Patrick Steinhardt <ps@pks.im> writes:
> 
> >  		} else if (skip_prefix(buf.buf, "option ", &arg)) {
> > +			const char *value = strchr(arg, ' ');
> > +			size_t arglen;
> >  			int result;
> >  
> > +			if (value) {
> > +				arglen = value - arg;
> > +				value++;
> > +			} else {
> > +				arglen = strlen(arg);
> >  				value = "true";
> > +			}
> 
> There is a micro optimization opportunity here.
> 
> 	const char *value = strchrnul(arg, ' ');
> 	size_t arglen = value - arg;
> 
> 	if (*value)
> 		value++; /* skip over SP */
> 	else
> 		value = "true";
> 
> But other than that, very cleanly done.