[PATCH v4 14/27] pretty: add casts for decoration option pointers
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 4, 2024, 12:37 UTC
- Message-ID
- <e057ead2b49cec1f5d7d5df1bf172bc45d139478.1717504517.git.ps@pks.im>
- In-Reply-To
- <cover.1717504517.git.ps@pks.im>
The `struct decoration_options` have a prefix and suffix field which are both non-constant, but we assign a constant pointer to them. This is safe to do because we pass them to `format_decorations()`, which never modifies these pointers, and then immediately discard the structure. Add explicit casts to avoid compilation warnings with `-Wwrite-strings`.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- pretty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pretty.c b/pretty.c index ec05db5655..1df9d635fb 100644 --- a/pretty.c +++ b/pretty.c @@ -1584,8 +1584,8 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ case 'D': { const struct decoration_options opts = { - .prefix = "", - .suffix = "" + .prefix = (char *) "", + .suffix = (char *) "", }; format_decorations(sb, commit, c->auto_color, &opts);
-- 2.45.1.410.g58bac47f8e.dirty