Re: [PATCH v3 0/2] t1100: modernize test script

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 14, 2026, 15:34 UTC
Message-ID: <xmqqh5m1vb36.fsf@gitster.g>
In-Reply-To: <alZADk3gB5GRxUiC@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 16 quoted lines

> On Tue, Jul 14, 2026 at 05:50:31PM +0530, Shlok Kulshreshtha wrote:
>> This is v3 of the microproject cleaning up
>> t/t1100-commit-tree-options.sh ("Modernize a test script").
>> 
>> Apologies, v2 crossed with Patrick's review of v1. This v3 folds in his
>> feedback as well.
>> 
>> Changes since v2:
>>   - Patch 1/2: also drop the extraneous blank line before the "flags
>>     and then non flags" test, as Patrick suggested.
>> 
>> Changes since v1 (carried over from v2):
>>   - Patch 2/2: reword the commit message to use the present tense, as
>>     Junio suggested.
>
> Thanks, this version looks good to me.

Thanks.