git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] t1100: modernize test style

From
Shlok Kulshreshtha <diy2903@gmail.com>
Date
Jul 14, 2026, 07:16 UTC
Message-ID
<20260714071633.35446-2-diy2903@gmail.com>
In-Reply-To
<20260714071633.35446-1-diy2903@gmail.com>

The tests in this script use the old style in which the test title and body are passed as separate backslash-continued arguments, with bodies indented using spaces:

    test_expect_success \
        'title' \
        'body'

Convert them to the modern style in which the body is a single-quoted block on its own lines, indented with a tab:

    test_expect_success 'title' '
        body
    '
This is a style-only change; no test logic is modified.
Signed-off-by: Shlok Kulshreshtha <diy2903@gmail.com>
---
 t/t1100-commit-tree-options.sh | 44 +++++++++++++++++-----------------
 1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh
index ae66ba5bab..fabe5a97cb 100755
--- a/t/t1100-commit-tree-options.sh
+++ b/t/t1100-commit-tree-options.sh
@@ -22,28 +22,28 @@ committer Committer Name <committer@email> 1117150200 +0000
 comment text
 EOF
 
-test_expect_success \
-    'test preparation: write empty tree' \
-    'git write-tree >treeid'
-
-test_expect_success \
-    'construct commit' \
-    'echo comment text |
-     GIT_AUTHOR_NAME="Author Name" \
-     GIT_AUTHOR_EMAIL="author@email" \
-     GIT_AUTHOR_DATE="2005-05-26 23:00" \
-     GIT_COMMITTER_NAME="Committer Name" \
-     GIT_COMMITTER_EMAIL="committer@email" \
-     GIT_COMMITTER_DATE="2005-05-26 23:30" \
-     TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null'
-
-test_expect_success \
-    'read commit' \
-    'git cat-file commit $(cat commitid) >commit'
-
-test_expect_success \
-    'compare commit' \
-    'test_cmp expected commit'
+test_expect_success 'test preparation: write empty tree' '
+	git write-tree >treeid
+'
+
+test_expect_success 'construct commit' '
+	echo comment text |
+	GIT_AUTHOR_NAME="Author Name" \
+	GIT_AUTHOR_EMAIL="author@email" \
+	GIT_AUTHOR_DATE="2005-05-26 23:00" \
+	GIT_COMMITTER_NAME="Committer Name" \
+	GIT_COMMITTER_EMAIL="committer@email" \
+	GIT_COMMITTER_DATE="2005-05-26 23:30" \
+	TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null
+'
+
+test_expect_success 'read commit' '
+	git cat-file commit $(cat commitid) >commit
+'
+
+test_expect_success 'compare commit' '
+	test_cmp expected commit
+'
 
 
 test_expect_success 'flags and then non flags' '
-- 
2.52.0
Previous: Shlok KulshreshthaNext: Shlok Kulshreshtha
Message 8 of 15 in “t1100: modernize test script”
  1. 0/2 t1100: modernize test scriptShlok Kulshreshtha, Jul 13, 2026
  2. 1/2 t1100: modernize test styleShlok Kulshreshtha, Jul 13, 2026
  3. Junio C HamanoJul 13, 2026
  4. Patrick SteinhardtJul 14, 2026
  5. 2/2 t1100: move creation of expected output into setup testShlok Kulshreshtha, Jul 13, 2026
  6. Junio C HamanoJul 13, 2026
  7. 0/2 t1100: modernize test scriptShlok Kulshreshtha, Jul 14, 2026
  8. 1/2 t1100: modernize test styleShlok Kulshreshtha, Jul 14, 2026
  9. 2/2 t1100: move creation of expected output into setup testShlok Kulshreshtha, Jul 14, 2026
  10. 0/2 t1100: modernize test scriptShlok Kulshreshtha, Jul 14, 2026
  11. 1/2 t1100: modernize test styleShlok Kulshreshtha, Jul 14, 2026
  12. 2/2 t1100: move creation of expected output into setup testShlok Kulshreshtha, Jul 14, 2026
  13. Patrick SteinhardtJul 14, 2026
  14. Junio C HamanoJul 14, 2026
  15. Junio C HamanoJul 14, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.