Re: [PATCH v3 0/2] t1100: modernize test script

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 14, 2026, 13:56 UTC
Message-ID: <alZADk3gB5GRxUiC@pks.im>
In-Reply-To: <20260714122033.61947-1-diy2903@gmail.com>

On Tue, Jul 14, 2026 at 05:50:31PM +0530, Shlok Kulshreshtha wrote:

Show 13 quoted lines

> This is v3 of the microproject cleaning up
> t/t1100-commit-tree-options.sh ("Modernize a test script").
> 
> Apologies, v2 crossed with Patrick's review of v1. This v3 folds in his
> feedback as well.
> 
> Changes since v2:
>   - Patch 1/2: also drop the extraneous blank line before the "flags
>     and then non flags" test, as Patrick suggested.
> 
> Changes since v1 (carried over from v2):
>   - Patch 2/2: reword the commit message to use the present tense, as
>     Junio suggested.

Thanks, this version looks good to me.

Patrick