Re: [PATCH v6 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 2, 2026, 21:05 UTC
Message-ID: <xmqqh5k7gy9k.fsf@gitster.g>
In-Reply-To: <B02189AD-DEC3-4117-8505-AAFA56494822@gmail.com>

Ben Knoble <ben.knoble@gmail.com> writes:

Show 8 quoted lines

>> My suggestion wasn't really about supporting more cases, but just about
>> making the code simpler by having one less #ifdef. But like I said
>> earlier, we can't get rid of the NO_NSEC knob entirely, so it's probably
>> not worth worrying about the one #ifdef either way.
>> 
>> -Peff
>
> Right on. Always good to find myself nodding along with your explanations :)

OK. So will we see a hopefully small and final reroll that takes advantage of the fact that ST_XTIME_NSEC(st) would usefully hide the NO_NSEC build-time differences?

I still am worried that something that sits this deep in the callchain can easily BUG() when working on a repository that is not the_repository due to the use of repo_config_values(), and we might be better off adopting safe default when istate->repo is different from the_repository, but other than that, I think the series is in great shape.

Thanks.