Re: [PATCH v6 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec
Show 16 quoted lines
> Le 2 sept. 2026 à 17:05, Junio C Hamano <gitster@pobox.com> a écrit :
>
> Ben Knoble <ben.knoble@gmail.com> writes:
>
>>> My suggestion wasn't really about supporting more cases, but just about
>>> making the code simpler by having one less #ifdef. But like I said
>>> earlier, we can't get rid of the NO_NSEC knob entirely, so it's probably
>>> not worth worrying about the one #ifdef either way.
>>>
>>> -Peff
>>
>> Right on. Always good to find myself nodding along with your explanations :)
>
> OK. So will we see a hopefully small and final reroll that takes
> advantage of the fact that ST_XTIME_NSEC(st) would usefully hide the
> NO_NSEC build-time differences?
Ah, no: I wasn’t planning on removing this ifdef, as I think Peff and I agree that it’s not worth the hassle (at least for now).
Show 8 quoted lines
> I still am worried that something that sits this deep in the
> callchain can easily BUG() when working on a repository that is not
> the_repository due to the use of repo_config_values(), and we might
> be better off adopting safe default when istate->repo is different
> from the_repository, but other than that, I think the series is in
> great shape.
>
> Thanks.
Yea. See previous messages re: convincing the test apparatus to set this globally. If I could run it that way at least locally, it would go a little ways towards scaring those BUGs out into the light.
Absent suggestions, though, I’m afraid my time is limited to explore the guts of yet another subsystem ;)
Ben Knoble <ben.knoble@gmail.com>