Re: [PATCH v6 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 3, 2026, 15:56 UTC
Message-ID: <xmqqbjaefhwo.fsf@gitster.g>
In-Reply-To: <842F2470-F158-4E77-AD98-DEA530FC4460@gmail.com>

Ben Knoble <ben.knoble@gmail.com> writes:

Show 8 quoted lines

>> I still am worried that something that sits this deep in the
>> callchain can easily BUG() when working on a repository that is not
>> the_repository due to the use of repo_config_values(), and we might
>> be better off adopting safe default when istate->repo is different
>> from the_repository, but other than that, I think the series is in
>> great shape.
>> 
>> Thanks.

[administrivia: wrap overly long lines]

> Yea. See previous messages re: convincing the test apparatus to
> set this globally. If I could run it that way at least locally, it
> would go a little ways towards scaring those BUGs out into the
> light.

I am not worried too much about the current code. I am more worried about how much this will hinder future development of new features, e.g., diff or status recursively going into submodules without spawning subprocesses, which is done for grep already. Testing and seeing 'git grep --recurse-submodule' not hitting a BUG() does not assure us all that much, as I do not think it needs to deal with racily clean entries any specially.

Thanks.