Re: [PATCH v4 1/2] doc: remove gittutorial
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2026, 18:01 UTC
- Message-ID
- <xmqqh5i5aemi.fsf@gitster.g>
- In-Reply-To
- <64d9811539b531104d01ae4382c90230eea01c61.1793198687.git.gitgitgadget@gmail.com>
"Julia Evans via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 13 quoted lines
> From: Julia Evans <julia@jvns.ca> > > The next commit replaces it with a new tutorial. > > Do this as a remove/add instead of just replacing the file in a single > commit to make the patches easier to read on the mailing list, since the > existing content isn't being reused. > > Signed-off-by: Julia Evans <julia@jvns.ca> > --- > Documentation/gittutorial.adoc | 671 --------------------------------- > 1 file changed, 671 deletions(-) > delete mode 100644 Documentation/gittutorial.adoc
Strictly speaking, this step alone would break "make check-docs" because it fails to remove the reference to the removed document that is in Documentation/git.adoc file. To be peanticly correct, this step must remove the reference from there, and then the next step must add it back, to make sure each and every step of the patch series builds and tests correctly.
$ make check-docs
...
LINT GITLINK git.adoc
git.adoc:1211: error: gittutorial[7]: link outside of our own docs, shown with 'HERE' below:
git.adoc:1211: 'linkgit:gittutorial[7]' <-- HEREI personally am too busy to worry about the "each and every step must correctly build and test" rule while flipping 100+ topics in 'seen' myself, so I'll update this topic in 'seen' as-is, but if we ever need rerolling this series, then we may want to remember cleaning it up.
Having said all that, it seems to me that this version is now in a pretty good shape to be merged to 'next'?
Thanks.