Re: [PATCH v4 1/2] doc: remove gittutorial
- From
Julia Evans <julia@jvns.ca>
- Date
- Oct 30, 2026, 20:52 UTC
- Message-ID
- <9e07da3c-0e75-41d2-8769-1347b3827ba6@app.fastmail.com>
- In-Reply-To
- <xmqqh5i5aemi.fsf@gitster.g>
On Wed, Oct 28, 2026, at 2:01 PM, Junio C Hamano wrote:
Show 35 quoted lines
> "Julia Evans via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> From: Julia Evans <julia@jvns.ca> >> >> The next commit replaces it with a new tutorial. >> >> Do this as a remove/add instead of just replacing the file in a single >> commit to make the patches easier to read on the mailing list, since the >> existing content isn't being reused. >> >> Signed-off-by: Julia Evans <julia@jvns.ca> >> --- >> Documentation/gittutorial.adoc | 671 --------------------------------- >> 1 file changed, 671 deletions(-) >> delete mode 100644 Documentation/gittutorial.adoc > > Strictly speaking, this step alone would break "make check-docs" > because it fails to remove the reference to the removed document > that is in Documentation/git.adoc file. To be peanticly correct, > this step must remove the reference from there, and then the next > step must add it back, to make sure each and every step of the patch > series builds and tests correctly. > > $ make check-docs > ... > LINT GITLINK git.adoc > git.adoc:1211: error: gittutorial[7]: link outside of our own docs, > shown with 'HERE' below: > git.adoc:1211: 'linkgit:gittutorial[7]' <-- HERE > > I personally am too busy to worry about the "each and every step > must correctly build and test" rule while flipping 100+ topics in > 'seen' myself, so I'll update this topic in 'seen' as-is, but if we > ever need rerolling this series, then we may want to remember > cleaning it up.
I tried to fix this, but there are quite a few references to the tutorial (including in `git.adoc`) and removing all of them would cause some merge conflicts which I believe would cause more work for you. I can remove them if you think that's best though.
> Having said all that, it seems to me that this version is now in a > pretty good shape to be merged to 'next'? > > Thanks.