git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] log: properly handle decorations with chained tags

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 19, 2013, 18:44 UTC
Message-ID
<xmqqfvpofzp5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20131219031809.GG259467@vauxhall.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 8 quoted lines
> On Tue, Dec 17, 2013 at 04:36:06PM -0800, Junio C Hamano wrote:
>> I think all we need to do, in addition to what the existing code
>> does, is to make sure that we _parse_ the object that the tag points
>> at, to avoid this problem.  Something like this, perhaps, instead?
>
> Yeah, that's the clean fix I was looking for, but couldn't quite come up
> with.  I'm going to re-roll with your fix instead of mine and my tests.
> Any objections to adding your sign-off?

I was actually planning to just squash 35a34ce281 as a fixup! to your 5e65a201 and call it a day. I think your proposed log message in the latter clearly describes why the fix is correct.

Previous: brian m. carlsonNext: brian m. carlson
Message 8 of 11 in “git log --no-walk --tags produces strange result for certain user”
  1. Kirill LikhodedovDec 3, 2013
  2. Kirill LikhodedovDec 7, 2013
  3. Kirill LikhodedovDec 16, 2013
  4. brian m. carlsonDec 17, 2013
  5. log: properly handle decorations with chained tagsbrian m. carlson, Dec 17, 2013
  6. Junio C HamanoDec 18, 2013
  7. brian m. carlsonDec 19, 2013
  8. Junio C HamanoDec 19, 2013
  9. brian m. carlsonDec 19, 2013
  10. Michael HaggertyJan 16, 2014
  11. Michael HaggertyJan 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.