git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] log: properly handle decorations with chained tags

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Dec 19, 2013, 03:18 UTC
Message-ID
<20131219031809.GG259467@vauxhall.crustytoothpaste.net>
In-Reply-To
<xmqq38lrknbd.fsf@gitster.dls.corp.google.com>
On Tue, Dec 17, 2013 at 04:36:06PM -0800, Junio C Hamano wrote:
> I think all we need to do, in addition to what the existing code
> does, is to make sure that we _parse_ the object that the tag points
> at, to avoid this problem.  Something like this, perhaps, instead?

Yeah, that's the clean fix I was looking for, but couldn't quite come up with. I'm going to re-roll with your fix instead of mine and my tests. Any objections to adding your sign-off?

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 11 in “git log --no-walk --tags produces strange result for certain user”
  1. Kirill LikhodedovDec 3, 2013
  2. Kirill LikhodedovDec 7, 2013
  3. Kirill LikhodedovDec 16, 2013
  4. brian m. carlsonDec 17, 2013
  5. log: properly handle decorations with chained tagsbrian m. carlson, Dec 17, 2013
  6. Junio C HamanoDec 18, 2013
  7. brian m. carlsonDec 19, 2013
  8. Junio C HamanoDec 19, 2013
  9. brian m. carlsonDec 19, 2013
  10. Michael HaggertyJan 16, 2014
  11. Michael HaggertyJan 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.