From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Dec 2013 18:44:22 GMT
Subject: Re: [PATCH] log: properly handle decorations with chained tags
Message-ID: <xmqqfvpofzp5.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131219031809.GG259467@vauxhall.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> On Tue, Dec 17, 2013 at 04:36:06PM -0800, Junio C Hamano wrote:
>> I think all we need to do, in addition to what the existing code
>> does, is to make sure that we _parse_ the object that the tag points
>> at, to avoid this problem.  Something like this, perhaps, instead?
>
> Yeah, that's the clean fix I was looking for, but couldn't quite come up
> with.  I'm going to re-roll with your fix instead of mine and my tests.
> Any objections to adding your sign-off?

I was actually planning to just squash 35a34ce281 as a fixup! to
your 5e65a201 and call it a day.  I think your proposed log message
in the latter clearly describes why the fix is correct.