git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Fix verify_lock() to report errors via strbuf

From
Junio C Hamano <gitster@pobox.com>
Date
May 27, 2015, 19:55 UTC
Message-ID
<xmqqfv6hlrs1.fsf@gitster.dls.corp.google.com>
In-Reply-To
<5565B1AE.3010708@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 9 quoted lines
> The last sentence is nonsense. This patch series relies on
> lock_ref_sha1_basic() having a "strbuf *err" parameter, which is only
> the case since
>
>     4a32b2e lock_ref_sha1_basic(): report errors via a "struct strbuf
> *err" (2015-05-11)
>
> The latter commit is in mh/ref-directory-file (which has now been merged
> to master, so technically the last sentence is now correct again).

[5/5] seems to conflict with the write_ref_sha1() vs write_ref_to_lockfile() updates; I think I can manage, though ;-)

Previous: Michael Haggerty
Message 12 of 12 in “Fix verify_lock() to report errors via strbuf”
  1. 0/5 Fix verify_lock() to report errors via strbufMichael Haggerty, May 22, 2015
  2. 1/5 verify_lock(): return 0/-1 rather than struct ref_lock *Michael Haggerty, May 22, 2015
  3. Stefan BellerMay 23, 2015
  4. 2/5 verify_lock(): on errors, let the caller unlock the lockMichael Haggerty, May 22, 2015
  5. 3/5 verify_lock(): report errors via a strbufMichael Haggerty, May 22, 2015
  6. Junio C HamanoMay 27, 2015
  7. Michael HaggertyMay 27, 2015
  8. 4/5 verify_lock(): do not capitalize error messagesMichael Haggerty, May 22, 2015
  9. 5/5 ref_transaction_commit(): do not capitalize error messagesMichael Haggerty, May 22, 2015
  10. Stefan BellerMay 23, 2015
  11. Michael HaggertyMay 27, 2015
  12. Junio C HamanoMay 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.