git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] verify_lock(): report errors via a strbuf

From
Junio C Hamano <gitster@pobox.com>
Date
May 27, 2015, 19:48 UTC
Message-ID
<xmqqk2vtls2q.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1432337697-29161-4-git-send-email-mhagger@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
> Instead of writing error messages directly to stderr, write them to a
> "strbuf *err". In lock_ref_sha1_basic(), arrange for these errors to
> be returned to its caller.

I had to scratch my head and view long outside the context before realizing that the caller lock_ref_sha1_basic() already arranges with its caller that errors from it are passed via the strbuf, and this change is just turning verify_lock(), a callee from it, follows that already established pattern.

Looks sensible, but the last sentence was misleading at least to me.
	The caller, lock_ref_sha1_basic(), uses this error reporting
	convention with all the other callees, and reports its error
        this way to its callers.
perhaps?
Previous: Michael HaggertyNext: Michael Haggerty
Message 6 of 12 in “Fix verify_lock() to report errors via strbuf”
  1. 0/5 Fix verify_lock() to report errors via strbufMichael Haggerty, May 22, 2015
  2. 1/5 verify_lock(): return 0/-1 rather than struct ref_lock *Michael Haggerty, May 22, 2015
  3. Stefan BellerMay 23, 2015
  4. 2/5 verify_lock(): on errors, let the caller unlock the lockMichael Haggerty, May 22, 2015
  5. 3/5 verify_lock(): report errors via a strbufMichael Haggerty, May 22, 2015
  6. Junio C HamanoMay 27, 2015
  7. Michael HaggertyMay 27, 2015
  8. 4/5 verify_lock(): do not capitalize error messagesMichael Haggerty, May 22, 2015
  9. 5/5 ref_transaction_commit(): do not capitalize error messagesMichael Haggerty, May 22, 2015
  10. Stefan BellerMay 23, 2015
  11. Michael HaggertyMay 27, 2015
  12. Junio C HamanoMay 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.