git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 06/11] ref-filter: implement '--merged' and '--no-merged' options

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 30, 2015, 15:58 UTC
Message-ID
<xmqqfv5989yg.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAOLa=ZSqvtXioRzeekjCAL3HoFsQmaLKQF=9YmftjQasiHvpqg@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 9 quoted lines
>> I also have a feeling that compared to an implementation based on
>> paint_down_to_common(), including is_descendant_of(), this may be
>> less precise (e.g. it would be confused with clock skew that lasts
>> more than SLOP commits).  If we are inventing a new helper (as
>> opposed to moving an existing one), we'd probably be better off
>> doing a thin wrapper around paint_down_to_common() than calling
>> revision-walk machinery.
>
> I'll have a look and get back to you.

Not as part of this series, now I know it is a straight-forward port of what we already have for "branch --merged". This series is not yet about improving counting logic but first unifying the three.

Thanks.
Previous: Karthik NayakNext: Karthik Nayak
Message 17 of 25 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refKarthik Nayak, Jun 25, 2015
  2. 01/11 t6302: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 25, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jun 25, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 25, 2015
  5. Junio C HamanoJun 29, 2015
  6. Karthik NayakJun 29, 2015
  7. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 25, 2015
  8. Junio C HamanoJun 29, 2015
  9. Karthik NayakJun 29, 2015
  10. Junio C HamanoJun 29, 2015
  11. Karthik NayakJun 29, 2015
  12. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 25, 2015
  13. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 25, 2015
  14. Junio C HamanoJun 29, 2015
  15. Junio C HamanoJun 29, 2015
  16. Karthik NayakJun 30, 2015
  17. Junio C HamanoJun 30, 2015
  18. Karthik NayakJun 30, 2015
  19. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 25, 2015
  20. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 25, 2015
  21. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 25, 2015
  22. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jun 25, 2015
  23. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jun 25, 2015
  24. Junio C HamanoJun 29, 2015
  25. Karthik NayakJun 29, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.