git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 04/11] for-each-ref: add '--points-at' option

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jun 29, 2015, 19:11 UTC
Message-ID
<CAOLa=ZRfgMtkVbYTf3NR7pXz+OmUZ3H1hiquGU2-hYy2NP87wQ@mail.gmail.com>
In-Reply-To
<xmqqk2um9x7w.fsf@gitster.dls.corp.google.com>
On Tue, Jun 30, 2015 at 12:08 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +test_expect_success 'check signed tags with --points-at' '
>> +     cat >expect <<-\EOF &&
>> +     refs/heads/side
>> +     refs/tags/four
>> +     refs/tags/signed-tag four
>> +     EOF
>> +     git for-each-ref --format="%(refname) %(*subject)" --points-at=side >actual &&
>> +     test_cmp expect actual
>> +'
>
> This piece seems to fail without a trailing whitespace in the
> expected file.  I initially suspected that they were dropped
> on my end while applying with "git am --whitespace=fix", but going
> back to my mailbox, it seems that what gmane received does not have
> them in the first place:
>
>         sed -e "s/Z$//" <<-\EOF &&
>         refs/heads/side Z
>         refs/tags/four Z
>         refs/tags/signed-tag four
>         EOF
>
> or something like that to make the EOL more visible to those who are
> reading the tests, perhaps?
Thanks, will use sed like you suggested.
-- 
Regards,
Karthik Nayak
Previous: Junio C HamanoNext: Karthik Nayak
Message 11 of 25 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refKarthik Nayak, Jun 25, 2015
  2. 01/11 t6302: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 25, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jun 25, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 25, 2015
  5. Junio C HamanoJun 29, 2015
  6. Karthik NayakJun 29, 2015
  7. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 25, 2015
  8. Junio C HamanoJun 29, 2015
  9. Karthik NayakJun 29, 2015
  10. Junio C HamanoJun 29, 2015
  11. Karthik NayakJun 29, 2015
  12. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 25, 2015
  13. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 25, 2015
  14. Junio C HamanoJun 29, 2015
  15. Junio C HamanoJun 29, 2015
  16. Karthik NayakJun 30, 2015
  17. Junio C HamanoJun 30, 2015
  18. Karthik NayakJun 30, 2015
  19. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 25, 2015
  20. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 25, 2015
  21. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 25, 2015
  22. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jun 25, 2015
  23. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jun 25, 2015
  24. Junio C HamanoJun 29, 2015
  25. Karthik NayakJun 29, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.