git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] am: rename "struct tree_desc t" to "desc" for readability

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 21, 2015, 16:51 UTC
Message-ID
<xmqqfv3c7ffm.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1440144151-24026-3-git-send-email-davvid@gmail.com>
David Aguilar <davvid@gmail.com> writes:
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
>  builtin/am.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Naming the tree_desc parameter given to unpack_trees() as "t" is (unfortunately) an established convention, just like we often use "i" and "j" in for() loop control.

Descriptive names are nicer, especially on the calling sites, but we have quite a many hits from

    $ git grep unpack_trees\( \*.c

so perhaps do this as a clean-up patch after dust settles for all the existing callers in archive, clone, commit, merge, read-tree, reset, diff-lib, and merge-recursive?

Previous: David Aguilar
Message 5 of 5 in “t4151: demonstrate that builtin am corrupts index' stat data”
  1. 1/3 t4151: demonstrate that builtin am corrupts index' stat dataDavid Aguilar, Aug 21, 2015
  2. 2/3 am: do not corrupt the index stat stateDavid Aguilar, Aug 21, 2015
  3. Junio C HamanoAug 21, 2015
  4. 3/3 am: rename "struct tree_desc t" to "desc" for readabilityDavid Aguilar, Aug 21, 2015
  5. Junio C HamanoAug 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.