Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 2, 2016, 22:05 UTC
- Message-ID
- <xmqqfuu0qfo4.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <57273A0B.5050409@web.de>
Torsten Bögershausen <tboegi@web.de> writes:
> git://host:[port]/path/to/repo > Knowing that, the "@" will be feed into the name resolver, > and that's OK.
Is it OK? It is plausible that our client side may even want to accept git://user:pass@host:port/local/part, and as an anonymous service, allow it to go to git://host:port/local/part without sending user:pass part over the wire. Or with the same knowledge that git:// is an anonymous service, it is also a plausible policy to error such a request out. To implement either needs a robust parsing of the URL, doesn't it?