[PATCH v3 0/6] connect: various cleanups

From: Mike Hommey <mh@glandium.org>
Date: May 1, 2016, 06:02 UTC
Message-ID: <1462082573-17992-1-git-send-email-mh@glandium.org>

On Fri, Apr 29, 2016 at 09:58:37AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> So I would suggest restructuring this series to do
> 
>  * 2/3 (DIAG consolidation)
>  * refactoring in 3/3 but not s/static/extern/
> 
> and in optional follow(s)-up, do
> 
>  * s/static/extern/ and update to *.h in 3/3
> 
>  * 1/3, but I do not think it is necessary for users of
>    prepare_ssh_command()

I went a little further on the restructuring and did some more cleanup. This could probably go even further, but that'd be well out of the scope I started those patches for :)

The order in which the changes have been done in this new series is debatable, but I thought the split in smaller parts made things easier to review, even if they could have been done in different orders.

I'm leaving the optional follows-up for now. I'll work around the functions being static somehow on my end.

Mike Hommey (6):
  connect: remove get_port()
  connect: uniformize and group CONNECT_DIAG_URL handling code
  connect: only match the host with core.gitProxy
  connect: pass separate host and port to git_tcp_connect and
    git_proxy_connect
  connect: don't xstrdup target_host
  connect: move ssh command line preparation to a separate function

 connect.c             | 184 ++++++++++++++++++++++----------------------------
 t/t5500-fetch-pack.sh |  25 ++++---
 2 files changed, 95 insertions(+), 114 deletions(-)

-- 
2.8.1.16.g58dac65.dirty