git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 06/11] diff: rename struct diff_filespec's sha1_valid member

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 25, 2016, 00:29 UTC
Message-ID
<xmqqfus2dsbl.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160624230929.82222-7-sandals@crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 11 quoted lines
> @@
> struct diff_filespec o;
> @@
> - o.sha1_valid
> + o.oid_valid
>
> @@
> struct diff_filespec *p;
> @@
> - p->sha1_valid
> + p->oid_valid

Totally offtopic (from Git's point of view), but why does Coccinelle need both of these? I recall that between v1 and v2 there were some confusing discussions about the order of these equivalent conversions mattering and the tool producing an incorrect conversion in v1.

Previous: brian m. carlsonNext: brian m. carlson
Message 12 of 14 in “struct object_id, Part 4”
  1. 00/11 struct object_id, Part 4brian m. carlson, Jun 24, 2016
  2. 01/11 hex: add oid_to_hex_r.brian m. carlson, Jun 24, 2016
  3. 03/11 Convert hashcpy with null_sha1 to hashclr.brian m. carlson, Jun 24, 2016
  4. 04/11 coccinelle: apply object_id Coccinelle transformationsbrian m. carlson, Jun 24, 2016
  5. 05/11 diff: convert struct diff_filespec to struct object_idbrian m. carlson, Jun 24, 2016
  6. 10/11 merge-recursive: convert merge_recursive_generic to object_idbrian m. carlson, Jun 24, 2016
  7. 09/11 merge-recursive: convert leaf functions to use struct object_idbrian m. carlson, Jun 24, 2016
  8. 11/11 diff: convert prep_temp_blob to struct object_id.brian m. carlson, Jun 24, 2016
  9. 07/11 merge-recursive: convert struct stage_data to use object_idbrian m. carlson, Jun 24, 2016
  10. 02/11 contrib/coccinelle: add basic Coccinelle transformsbrian m. carlson, Jun 24, 2016
  11. 06/11 diff: rename struct diff_filespec's sha1_valid memberbrian m. carlson, Jun 24, 2016
  12. Junio C HamanoJun 25, 2016
  13. brian m. carlsonJun 25, 2016
  14. 08/11 merge-recursive: convert struct merge_file_info to object_idbrian m. carlson, Jun 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.