From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 25 Jun 2016 00:29:18 GMT
Subject: Re: [PATCH v3 06/11] diff: rename struct diff_filespec's sha1_valid member
Message-ID: <xmqqfus2dsbl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160624230929.82222-7-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:


> @@
> struct diff_filespec o;
> @@
> - o.sha1_valid
> + o.oid_valid
>
> @@
> struct diff_filespec *p;
> @@
> - p->sha1_valid
> + p->oid_valid

Totally offtopic (from Git's point of view), but why does Coccinelle
need both of these?  I recall that between v1 and v2 there were some
confusing discussions about the order of these equivalent conversions
mattering and the tool producing an incorrect conversion in v1.