git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 11/11] diff: convert prep_temp_blob to struct object_id.

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jun 24, 2016, 23:09 UTC
Message-ID
<20160624230929.82222-12-sandals@crustytoothpaste.net>
In-Reply-To
<20160624230929.82222-1-sandals@crustytoothpaste.net>

All of the callers of this function use struct object_id, so convert it to use struct object_id in its arguments and internally.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 diff.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/diff.c b/diff.c
index 9abb54ad..8cdfdf32 100644
--- a/diff.c
+++ b/diff.c
@@ -2866,7 +2866,7 @@ void diff_free_filespec_data(struct diff_filespec *s)
 static void prep_temp_blob(const char *path, struct diff_tempfile *temp,
 			   void *blob,
 			   unsigned long size,
-			   const unsigned char *sha1,
+			   const struct object_id *oid,
 			   int mode)
 {
 	int fd;
@@ -2891,7 +2891,7 @@ static void prep_temp_blob(const char *path, struct diff_tempfile *temp,
 		die_errno("unable to write temp-file");
 	close_tempfile(&temp->tempfile);
 	temp->name = get_tempfile_path(&temp->tempfile);
-	sha1_to_hex_r(temp->hex, sha1);
+	oid_to_hex_r(temp->hex, oid);
 	xsnprintf(temp->mode, sizeof(temp->mode), "%06o", mode);
 	strbuf_release(&buf);
 	strbuf_release(&template);
@@ -2929,7 +2929,7 @@ static struct diff_tempfile *prepare_temp_file(const char *name,
 				die_errno("readlink(%s)", name);
 			prep_temp_blob(name, temp, sb.buf, sb.len,
 				       (one->oid_valid ?
-					one->oid.hash : null_sha1),
+					&one->oid : &null_oid),
 				       (one->oid_valid ?
 					one->mode : S_IFLNK));
 			strbuf_release(&sb);
@@ -2955,7 +2955,7 @@ static struct diff_tempfile *prepare_temp_file(const char *name,
 		if (diff_populate_filespec(one, 0))
 			die("cannot read data blob for %s", one->path);
 		prep_temp_blob(name, temp, one->data, one->size,
-			       one->oid.hash, one->mode);
+			       &one->oid, one->mode);
 	}
 	return temp;
 }
Previous: brian m. carlsonNext: brian m. carlson
Message 8 of 14 in “struct object_id, Part 4”
  1. 00/11 struct object_id, Part 4brian m. carlson, Jun 24, 2016
  2. 01/11 hex: add oid_to_hex_r.brian m. carlson, Jun 24, 2016
  3. 03/11 Convert hashcpy with null_sha1 to hashclr.brian m. carlson, Jun 24, 2016
  4. 04/11 coccinelle: apply object_id Coccinelle transformationsbrian m. carlson, Jun 24, 2016
  5. 05/11 diff: convert struct diff_filespec to struct object_idbrian m. carlson, Jun 24, 2016
  6. 10/11 merge-recursive: convert merge_recursive_generic to object_idbrian m. carlson, Jun 24, 2016
  7. 09/11 merge-recursive: convert leaf functions to use struct object_idbrian m. carlson, Jun 24, 2016
  8. 11/11 diff: convert prep_temp_blob to struct object_id.brian m. carlson, Jun 24, 2016
  9. 07/11 merge-recursive: convert struct stage_data to use object_idbrian m. carlson, Jun 24, 2016
  10. 02/11 contrib/coccinelle: add basic Coccinelle transformsbrian m. carlson, Jun 24, 2016
  11. 06/11 diff: rename struct diff_filespec's sha1_valid memberbrian m. carlson, Jun 24, 2016
  12. Junio C HamanoJun 25, 2016
  13. brian m. carlsonJun 25, 2016
  14. 08/11 merge-recursive: convert struct merge_file_info to object_idbrian m. carlson, Jun 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.