Re: [PATCH] test-lib: stricter unzip(1) check

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2016, 17:26 UTC
Message-ID: <xmqqfur5h730.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1607191327260.3472@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 16 quoted lines

> On Mon, 18 Jul 2016, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> > Hrm. That sounds a little magical, and fragile, to me. What if the next
>> > person's unzip returns 0 and *still* cannot handle -a?
>> 
>> That is a very sensible line of thought.
>> 
>> > I'd rather do something like
>> 
>> ... but the patch presented as an alternative does not seem to
>> follow that line of thought.
>
> Right. I tried to see whether I could come up with a test, but did not
> immediately succeed. The patch I presented was the best I could do...

Ah, OK, it makes sense.