Re: [PATCH] test-lib: stricter unzip(1) check

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 19, 2016, 11:27 UTC
Message-ID: <alpine.DEB.2.20.1607191327260.3472@virtualbox>
In-Reply-To: <xmqqtwfmkduk.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 18 Jul 2016, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Hrm. That sounds a little magical, and fragile, to me. What if the next
> > person's unzip returns 0 and *still* cannot handle -a?
> 
> That is a very sensible line of thought.
> 
> > I'd rather do something like
> 
> ... but the patch presented as an alternative does not seem to
> follow that line of thought.

Right. I tried to see whether I could come up with a test, but did not immediately succeed. The patch I presented was the best I could do...

Ciao, Dscho