Re: [PATCH] test-lib: stricter unzip(1) check

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2016, 21:27 UTC
Message-ID: <CAPc5daWnfA7C23Qa07Y-aYwWBebdn33qZMo4Sj+Evm3-fVUDcg@mail.gmail.com>
In-Reply-To: <20160718211951.GA62657@plume>

On Mon, Jul 18, 2016 at 2:19 PM, Eric Wong <e@80x24.org> wrote:

Show 9 quoted lines

> Thanks, but I think the test file is too small.  I tried
> setting up a test to store the text file as binary in the
> zip to check for inadvertant CRLF conversions:
>
>   printf 'text\r\n' >binary && zip -B infozip-binary.zip binary
>
> But zip -B/--binary only works on VM/CMS and MVS...
>
> So I'm inclined to go with Dscho's patch.

OK, I'll wait for the final reroll and queue it near 'next' when it happens.

Thanks.