Re: `git describe --dirty` doesn't consider untracked files to be dirty

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2020, 23:59 UTC
Message-ID: <xmqqft7rx1k7.fsf@gitster.c.googlers.com>
In-Reply-To: <20200908231652.GC1014@pug.qqx.org>

Aaron Schrab <aaron@schrab.com> writes:

Show 14 quoted lines

> It's perhaps worth noting that submodules are already considered dirty
> when untracked files are added:
>
> $ git diff vim/bundle/fugitive
>
> $ echo foo >vim/bundle/fugitive/foo
>
> $ git diff vim/bundle/fugitive
> diff --git i/vim/bundle/fugitive w/vim/bundle/fugitive
> --- i/vim/bundle/fugitive
> +++ w/vim/bundle/fugitive
> @@ -1 +1 @@
> -Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c
> +Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c-dirty

It gives one vote for (1) to the part you did not quote from the message you are responding to, which was:

Show 5 quoted lines

>> I do not think this is something we want to hide behind a
>> configuration knob, but I am undecided between (1) declare that this
>> is a bug and change the behaviour of "--dirty" and (2) declare that
>> we discovered another useful behaviour and add a new option next to
>> "--dirty".

I tend to agree the consistency with that behaviour would be more useful. The discrepanthy shows the relative age of features and how our thinking has changed over time ;-)