Re: `git describe --dirty` doesn't consider untracked files to be dirty

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 19, 2020, 18:12 UTC
Message-ID: <xmqqo8m1k542.fsf@gitster.c.googlers.com>
In-Reply-To: <20200908231652.GC1014@pug.qqx.org>

Aaron Schrab <aaron@schrab.com> writes:

Show 14 quoted lines

> It's perhaps worth noting that submodules are already considered dirty
> when untracked files are added:
>
> $ git diff vim/bundle/fugitive
>
> $ echo foo >vim/bundle/fugitive/foo
>
> $ git diff vim/bundle/fugitive
> diff --git i/vim/bundle/fugitive w/vim/bundle/fugitive
> --- i/vim/bundle/fugitive
> +++ w/vim/bundle/fugitive
> @@ -1 +1 @@
> -Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c
> +Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c-dirty

In other words, if we do this in the state:

  $ git -C vim/bundle/fugitive describe --dirty

the submodule directory is not reported as dirty.

This is worth fixing. I am leaning towards saying that `diff` is wrong in this case, but I am OK to consider unifying the behaviour the other way and making `describe --dirty` more strict.

Thanks.