From: Junio C Hamano Date: Tue, 08 Sep 2020 23:59:20 GMT Subject: Re: `git describe --dirty` doesn't consider untracked files to be dirty Message-ID: In-Reply-To: <20200908231652.GC1014@pug.qqx.org> Aaron Schrab writes: > It's perhaps worth noting that submodules are already considered dirty > when untracked files are added: > > $ git diff vim/bundle/fugitive > > $ echo foo >vim/bundle/fugitive/foo > > $ git diff vim/bundle/fugitive > diff --git i/vim/bundle/fugitive w/vim/bundle/fugitive > --- i/vim/bundle/fugitive > +++ w/vim/bundle/fugitive > @@ -1 +1 @@ > -Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c > +Subproject commit caf3b1d5696e8d39a905e48f1e89d8c0c565168c-dirty It gives one vote for (1) to the part you did not quote from the message you are responding to, which was: >> I do not think this is something we want to hide behind a >> configuration knob, but I am undecided between (1) declare that this >> is a bug and change the behaviour of "--dirty" and (2) declare that >> we discovered another useful behaviour and add a new option next to >> "--dirty". I tend to agree the consistency with that behaviour would be more useful. The discrepanthy shows the relative age of features and how our thinking has changed over time ;-)