Re: [PATCH 1/2] diffcore-rename: no point trying to find a match better than exact

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2021, 18:46 UTC
Message-ID: <xmqqft2dc7lj.fsf@gitster.c.googlers.com>
In-Reply-To: <515f55bd-90e2-9a7f-0973-501c9351969e@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 7 quoted lines

>>  	/* All done? */
>> -	if (!num_destinations)
>> +	if (!num_destinations || !num_sources)
>>  		goto cleanup;
>
> And add an extra quit condition which is very possible to hit.
> Is it only hit when every "delete" is actually a rename?

When every delete is actually an unmodified exact rename, I think. If this simple change gives us good performance gain, that is superb.

Nicely done.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.