Re: [PATCH v2 2/2] diffcore-rename: filter rename_src list when possible

From: Elijah Newren <newren@gmail.com>
Date: Feb 13, 2021, 04:24 UTC
Message-ID: <CABPp-BEpvx-pHQs3_mK-Wr=ZmZRwLD4vA64LLryU4ehqiCz58w@mail.gmail.com>
In-Reply-To: <xmqqczx4vkus.fsf@gitster.c.googlers.com>

On Fri, Feb 12, 2021 at 5:04 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > +             return; /* culling incompatbile with break detection */
>
> incompatible.

Thanks.

Show 7 quoted lines

> >       /*
> > -      * Calculate how many renames are left (but all the source
> > -      * files still remain as options for rename/copies!)
> > +      * Calculate how many renames are left
> >        */
>
> This no longer needs to be a multi-line comment, does it?

Indeed.

Will fix both.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.