From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 03 Feb 2021 18:46:32 GMT
Subject: Re: [PATCH 1/2] diffcore-rename: no point trying to find a match better than exact
Message-ID: <xmqqft2dc7lj.fsf@gitster.c.googlers.com>
In-Reply-To: <515f55bd-90e2-9a7f-0973-501c9351969e@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

>>  	/* All done? */
>> -	if (!num_destinations)
>> +	if (!num_destinations || !num_sources)
>>  		goto cleanup;
>
> And add an extra quit condition which is very possible to hit.
> Is it only hit when every "delete" is actually a rename?

When every delete is actually an unmodified exact rename, I think.
If this simple change gives us good performance gain, that is
superb.

Nicely done.