Re: [PATCH 2/5] *.[ch] *_INIT macros: use { 0 } for a "zero out" idiom
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 27, 2021, 20:25 UTC
- Message-ID
- <xmqqfstppxzm.fsf@gitster.g>
- In-Reply-To
- <68c9c6da-d215-a39b-64f5-8b8930ce5a09@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 13 quoted lines
> Am 27.09.21 um 02:39 schrieb Ævar Arnfjörð Bjarmason:
>> diff --git a/entry.h b/entry.h
>> index 7c889e58fd7..04bc8bb59f0 100644
>> --- a/entry.h
>> +++ b/entry.h
>> @@ -16,7 +16,7 @@ struct checkout {
>> clone:1,
>> refresh_cache:1;
>> };
>> -#define CHECKOUT_INIT { NULL, "" }
>> +#define CHECKOUT_INIT { 0 }
>
> This is not an equivalence transformation and does not belong in this patch.Thanks for carefully reading. This is the kind of mistake I hate about these mind-numbing "let's do the clean-up" series.