Re: [PATCH 5/5] cbtree.h: define cb_init() in terms of CBTREE_INIT

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 27, 2021, 06:37 UTC
Message-ID: <694f477d-b387-c8ea-4138-0e9334540c69@kdbg.org>
In-Reply-To: <patch-5.5-7e571667674-20210927T003330Z-avarab@gmail.com>

Am 27.09.21 um 02:39 schrieb Ævar Arnfjörð Bjarmason:

Show 13 quoted lines

> --- a/cbtree.h
> +++ b/cbtree.h
> @@ -37,11 +37,12 @@ enum cb_next {
>  	CB_BREAK = 1
>  };
>  
> -#define CBTREE_INIT { .root = NULL }
> +#define CBTREE_INIT { 0 }
>  
>  static inline void cb_init(struct cb_tree *t)
>  {
> -	t->root = NULL;
> +	struct cb_tree blank = CBTREE_INIT;

This could be

	static const struct cb_tree blank = CBTREE_INIT;

> +	memcpy(t, &blank, sizeof(*t));

Is
	*t = blank;

not a thing in C?

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.