Re: [PATCH v6 05/16] bisect--helper: make `terms` an explicit singleton

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2022, 21:28 UTC
Message-ID: <xmqqfshdifq5.fsf@gitster.g>
In-Reply-To: <xmqqmtblighr.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Well, I do not find the above all that convincing.

Having said all that, quite honestly, I do not care all that deeply.

It just looked suboptimal, even if we were to take the "as long as the end result 'works', we do not care" attitude, to deliberately make the code worse with a larger-than-necessary patch, and then complain that use of OPT_SUBCOMMAND() made you write unnecessary code.

Will push out another round of integration result sometime today and this series will be part of 'seen'.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.