Re: [PATCH 08/11] bisect--helper: using `--bisect-state` without an argument is a bug

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jan 29, 2022, 07:04 UTC
Message-ID: <220129.86leyzaunr.gmgdl@evledraar.gmail.com>
In-Reply-To: <1b14ed3d7976b8fe4149822dcbb32343e0554a38.1643328752.git.gitgitgadget@gmail.com>

On Fri, Jan 28 2022, Johannes Schindelin via GitGitGadget wrote:

Show 6 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The `bisect--helper` command is not expected to be used directly by the
> user. Therefore, it is a bug if it receives no argument to the
> `--bisect-state` command mode, not a user error. Which means that we
> need to call `BUG()` instead of `die()`.

I found this commit message confusing with 07/11. I.e. won't this be "git bisect" directly make this BUG() a bug then?

But no, it won't, because this being a bug has nothing to do with it being a helper at all. after 07/11, but that it'll be called from an implicit "if (!argc)" in cmd_bisect(), no?

I think I've either misread that, or this commit message is very misleading.