Re: [PATCH v5 05/16] bisect--helper: make `terms` an explicit singleton

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 29, 2022, 12:30 UTC
Message-ID: <s47684sr-p257-31n6-5qr7-0p29490rsp7q@tzk.qr>
In-Reply-To: <220829.86o7w32vv2.gmgdl@evledraar.gmail.com>

Hi Ævar,

On Mon, 29 Aug 2022, Ævar Arnfjörð Bjarmason wrote:

Show 19 quoted lines

>
> On Sat, Aug 27 2022, Johannes Schindelin via GitGitGadget wrote:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> > [...]
> > -	free((void *)terms->term_good);
> > -	terms->term_good = xstrdup(good);
> > -	free((void *)terms->term_bad);
> > -	terms->term_bad = xstrdup(bad);
> > +	free((void *)terms.term_good);
> > +	terms.term_good = xstrdup(good);
> > +	free((void *)terms.term_bad);
> > +	terms.term_bad = xstrdup(bad);
> >  }
>
> This is pre-existing, and dates back to 0f30233a11f (bisect--helper:
> `bisect_write` shell function in C, 2019-01-02), but it appears this
> cast to a "void *" was never needed. Perhaps some C++-ism that crept in
> here?

While this is all true, this feedback is about code that is not changed by this patch.

I am afraid that this review therefore misses the intention of the patch.

Ciao, Johannes