git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] remote: print an error if refspec cannot be removed

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2024, 17:38 UTC
Message-ID
<xmqqfrq3zc6n.fsf@gitster.g>
In-Reply-To
<acd287c8-990b-42b7-85dd-a206a887b8ee@gmail.com>
phillip.wood123@gmail.com writes:
Show 13 quoted lines
> On 11/09/2024 21:52, Junio C Hamano wrote:
>> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>>   	if (!add_mode && remove_all_fetch_refspecs(key.buf)) {
>>> +		error(_("could not remove existing fetch refspec"));
>>>   		strbuf_release(&key);
>>>   		return 1;
>>>   	}
>> It is a minor point, but would it help to say what we tried to
>> remove (e.g. "from remote X") or is it too obvious to the end user
>> in the context they get this error?
>
> The user has to give the remote name on the command line so I think it
> should be obvious to the user.
That makes sense.  Thanks.
Previous: phillip.wood123@gmail.comNext: Phillip Wood via GitGitGadget
Message 11 of 22 in “remote: branch setting fixes”
  1. 0/4 remote: branch setting fixesPhillip Wood via GitGitGadget, Sep 11, 2024
  2. 1/4 remote: fix set-branches when no branches are setPhillip Wood via GitGitGadget, Sep 11, 2024
  3. Junio C HamanoSep 11, 2024
  4. Patrick SteinhardtSep 12, 2024
  5. 2/4 remote: print an error if refspec cannot be removedPhillip Wood via GitGitGadget, Sep 11, 2024
  6. Junio C HamanoSep 11, 2024
  7. Patrick SteinhardtSep 12, 2024
  8. Junio C HamanoSep 12, 2024
  9. Patrick SteinhardtSep 13, 2024
  10. phillip.wood123@gmail.comSep 13, 2024
  11. Junio C HamanoSep 13, 2024
  12. 3/4 remote add: use strvec to store tracking branchesPhillip Wood via GitGitGadget, Sep 11, 2024
  13. Junio C HamanoSep 11, 2024
  14. Patrick SteinhardtSep 12, 2024
  15. 4/4 remote: check branch namesPhillip Wood via GitGitGadget, Sep 11, 2024
  16. Junio C HamanoSep 11, 2024
  17. Patrick SteinhardtSep 12, 2024
  18. Junio C HamanoSep 12, 2024
  19. phillip.wood123@gmail.comSep 13, 2024
  20. Junio C HamanoSep 13, 2024
  21. phillip.wood123@gmail.comSep 18, 2024
  22. Junio C HamanoSep 18, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.