Re: [PATCH 3/4] remote add: use strvec to store tracking branches
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 11, 2024, 17:05 UTC
- Message-ID
- <xmqq8qvy86kd.fsf@gitster.g>
- In-Reply-To
- <f30c77bc36072df57662cac0cb7bf1bbea378062.1726067917.git.gitgitgadget@gmail.com>
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 12 quoted lines
> From: Phillip Wood <phillip.wood@dunelm.org.uk> > > Store the list of branches to track in a ’struct strvec' instead of a > 'struct string_list'. This in preparation for the next commit where it > will be convenient to have them stored in a NULL terminated array. This > means that we now duplicate the strings when storing them but the > overhead is not significant. > > Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> > --- > builtin/remote.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-)
This has a slight conflict with a topic that has already graduated but nothing serious. If you need to reroll, you may want to base it on a bit more recent tip of 'master', younger than bb424845 (Merge branch 'rs/remote-leakfix', 2024-09-03).
Thanks.