From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 13 Sep 2024 17:38:24 GMT
Subject: Re: [PATCH 2/4] remote: print an error if refspec cannot be removed
Message-ID: <xmqqfrq3zc6n.fsf@gitster.g>
In-Reply-To: <acd287c8-990b-42b7-85dd-a206a887b8ee@gmail.com>

phillip.wood123@gmail.com writes:

> On 11/09/2024 21:52, Junio C Hamano wrote:
>> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>>   	if (!add_mode && remove_all_fetch_refspecs(key.buf)) {
>>> +		error(_("could not remove existing fetch refspec"));
>>>   		strbuf_release(&key);
>>>   		return 1;
>>>   	}
>> It is a minor point, but would it help to say what we tried to
>> remove (e.g. "from remote X") or is it too obvious to the end user
>> in the context they get this error?
>
> The user has to give the remote name on the command line so I think it
> should be obvious to the user.

That makes sense.  Thanks.