Re: [PATCH 0/2] solaris test fixups
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 23, 2014, 20:52 UTC
- Message-ID
- <xmqqeh3yto8h.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140123195404.GA31314@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> and assume that it will fail. It doesn't. Solaris happily renames > some-file to a regular file named "no-such-dir". So we fail later during > the index-update, complaining about adding the entry "no-such-dir/", but > still exit(0) at the end. I'm mostly willing to just call Solaris crazy > for allowing the rename (Linux returns ENOTDIR), but I do wonder if > the index codepath could be improved (and especially to return an > error).
I think j6t has a patch for that, a8933469 (mv: let 'git mv file no-such-dir/' error out on Windows, too, 2014-01-08).