git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t7700: do not use "touch -r"

From
Jeff King <peff@peff.net>
Date
Jan 23, 2014, 21:14 UTC
Message-ID
<20140123211425.GA21377@sigill.intra.peff.net>
In-Reply-To
<xmqq61patnag.fsf@gitster.dls.corp.google.com>
On Thu, Jan 23, 2014 at 01:12:55PM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > ... The test does not care about the timestamp of the
> > .keep file it creates at all, only that it exists.
> 
> Please refrain from using "touch" for such use cases in the first
> place.  It appears that
> 
> 	>pack-$packsha1.keep &&
> 
> is what the test wants.

Agreed. I was making the minimal change, but I think there is no reason not to fix both while we are there. Do you want to just mark up the patch in transit?

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 9 in “solaris test fixups”
  1. 0/2 solaris test fixupsJeff King, Jan 23, 2014
  2. 1/2 t7501: fix "empty commit" test with NO_PERLJeff King, Jan 23, 2014
  3. 2/2 t7700: do not use "touch -r"Jeff King, Jan 23, 2014
  4. Junio C HamanoJan 23, 2014
  5. Jeff KingJan 23, 2014
  6. Junio C HamanoJan 23, 2014
  7. Jeff KingJan 23, 2014
  8. Junio C HamanoJan 23, 2014
  9. Jeff KingJan 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.