Re: [PATCH 0/2] solaris test fixups

From: Jeff King <peff@peff.net>
Date: Jan 23, 2014, 20:54 UTC
Message-ID: <20140123205404.GA12757@sigill.intra.peff.net>
In-Reply-To: <xmqqeh3yto8h.fsf@gitster.dls.corp.google.com>

On Thu, Jan 23, 2014 at 12:52:30PM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > and assume that it will fail. It doesn't. Solaris happily renames
> > some-file to a regular file named "no-such-dir". So we fail later during
> > the index-update, complaining about adding the entry "no-such-dir/", but
> > still exit(0) at the end. I'm mostly willing to just call Solaris crazy
> > for allowing the rename (Linux returns ENOTDIR), but I do wonder if
> > the index codepath could be improved (and especially to return an
> > error).
> 
> I think j6t has a patch for that, a8933469 (mv: let 'git mv file
> no-such-dir/' error out on Windows, too, 2014-01-08).

Ah yeah, that looks like exactly the same issue (and the fix looks sane from my cursory investigation). Thanks for the pointer. I wasn't planning to look further into it, but now I can do so without feeling guilty. :)

-Peff