git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] bisect: simplify the add of new bisect terms

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 10, 2015, 15:10 UTC
Message-ID
<xmqqegljoayp.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpqk2vcat2t.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 12 quoted lines
> Louis-Alexandre Stuber <stuberl@ensimag.grenoble-inp.fr> writes:
>
>>> That is very different from ENOENT, which is an expected error when
>>> you are not using a customized terms.
>>
>> But in the current state, we are going to create bisect_terms even if
>> the bisection is in bad/good mode.
>
> Which means that in normal cases, you'll either succeed to open it, or
> get ENOENT. We're talking about unexcepted cases (you don't have
> permission to read it because it's not your file, because you messed up
> with a chmod, or whatever reason).

I think both I and you misunderstood what they wanted to do, which is to write out good and bad into terms file even though these are not customized, and then always read from terms file to learn what words are used for good and bad.

So from _that_ point of view, ENOENT is an error just like others.

But I do not think it is a good idea to penalize the normal case by writing the terms file and reading them back from it when the user is bisecting with good/bad in the first place, so....

Previous: Matthieu MoyNext: Matthieu Moy
Message 20 of 24 in “bisect : correction of typo”
  1. 1/4 bisect : correction of typoAntoine Delaite, Jun 8, 2015
  2. 2/4 bisect: replace hardcoded "bad|good" by variablesAntoine Delaite, Jun 8, 2015
  3. Junio C HamanoJun 8, 2015
  4. Matthieu MoyJun 9, 2015
  5. Christian CouderJun 9, 2015
  6. Matthieu MoyJun 9, 2015
  7. Junio C HamanoJun 9, 2015
  8. 3/4 bisect: simplify the add of new bisect termsAntoine Delaite, Jun 8, 2015
  9. Junio C HamanoJun 8, 2015
  10. Antoine DelaiteJun 9, 2015
  11. Matthieu MoyJun 10, 2015
  12. Matthieu MoyJun 9, 2015
  13. Christian CouderJun 9, 2015
  14. Louis-Alexandre StuberJun 9, 2015
  15. Junio C HamanoJun 10, 2015
  16. Louis-Alexandre StuberJun 10, 2015
  17. Matthieu MoyJun 10, 2015
  18. Louis-Alexandre StuberJun 10, 2015
  19. Matthieu MoyJun 10, 2015
  20. Junio C HamanoJun 10, 2015
  21. Matthieu MoyJun 10, 2015
  22. Junio C HamanoJun 10, 2015
  23. 4/4 bisect: add the terms old/newAntoine Delaite, Jun 8, 2015
  24. Junio C HamanoJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.