Re: [PATCH 3/4] bisect: simplify the add of new bisect terms

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 10, 2015, 16:30 UTC
Message-ID: <vpq4mmfv84i.fsf@anie.imag.fr>
In-Reply-To: <2139695602.323234.1433873829922.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:

Show 11 quoted lines

>>> +get_terms () {
>>> +        if test -s "$GIT_DIR/BISECT_TERMS"
>>> +        then
>>> +                NAME_BAD="$(sed -n 1p "$GIT_DIR/BISECT_TERMS")"
>>> +                NAME_GOOD="$(sed -n 2p "$GIT_DIR/BISECT_TERMS")"
>>
>>It is sad that we need to open the file twice.  Can't we do
>>something using "read" perhaps?
>
> The cost of it is quite low and we see directly what we meant. We didn't 
> found a pretty way to read two lines with read.

Should be stg like:

{
	read good
	read bad
} <"$GIT_DIR/BISECT_TERMS"

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/