git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/4] path: optimize common dir checking

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 17, 2015, 15:55 UTC
Message-ID
<xmqqegj1gb9h.fsf@gitster.dls.corp.google.com>
In-Reply-To
<55CF811A.8060106@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 5 quoted lines
> If I understand correctly, you consider the decision of where a
> particular reference should be stored to be a kind of "business logic"
> decision that should live outside of the refs module. I don't think it
> is so important whether this knowledge is inside or outside of the refs
> module (I can live with it either way).

I think I misspoke. The decision to make a particular reference, e.g. HEAD or 'master' branch, a per-workspace one or a repo-wide one, should not be made by individual refs backend (i.e. lower-half of the refs module). It could still be the responsibility of the upper-half of the refs module and that _feels_ more kosher.

But without actual implementation of the interface between upper- and lower-half of the refs module yet (as we only have fs based backend that is tightly integrated within the refs module and nothing else right now), I do not yet see a clear implementation for the "is this thing common?" table Duy did that decides where things go for everything except "refs/" part while letting the upper-half of the refs module to take responsiblity of that decision for refs. For one thing, "the refs module decides what is in refs/, Duy's table decides everything else " is not even the right partition, in the presence of things like HEAD, logs/, etc.

So...
Previous: Michael HaggertyNext: Duy Nguyen
Message 11 of 24 in “refs: clean up common_list”
  1. 1/4 refs: clean up common_listDavid Turner, Aug 12, 2015
  2. 2/4 path: optimize common dir checkingDavid Turner, Aug 12, 2015
  3. Junio C HamanoAug 12, 2015
  4. Michael HaggertyAug 13, 2015
  5. Junio C HamanoAug 14, 2015
  6. David TurnerAug 14, 2015
  7. Junio C HamanoAug 14, 2015
  8. David TurnerAug 14, 2015
  9. Michael HaggertyAug 15, 2015
  10. Michael HaggertyAug 15, 2015
  11. Junio C HamanoAug 17, 2015
  12. Duy NguyenAug 15, 2015
  13. David TurnerAug 16, 2015
  14. Duy NguyenAug 16, 2015
  15. 3/4 refs: make refs/worktree/* per-worktreeDavid Turner, Aug 12, 2015
  16. Eric SunshineAug 13, 2015
  17. David TurnerAug 13, 2015
  18. Michael HaggertyAug 13, 2015
  19. David TurnerAug 13, 2015
  20. Michael HaggertyAug 14, 2015
  21. Junio C HamanoAug 14, 2015
  22. Duy NguyenAug 15, 2015
  23. 4/4 bisect: make bisection refs per-worktreeDavid Turner, Aug 12, 2015
  24. Duy NguyenAug 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.