Re: [PATCH v3 3/4] refs: make refs/worktree/* per-worktree
- From
David Turner <dturner@twopensource.com>
- Date
- Aug 13, 2015, 17:41 UTC
- Message-ID
- <1439487708.8855.2.camel@twopensource.com>
- In-Reply-To
- <CAPig+cRM-J-5SHJ9JVsHPR+B2Y05nwFrRQWsd0M56pm9jS-mTQ@mail.gmail.com>
On Thu, 2015-08-13 at 13:15 -0400, Eric Sunshine wrote:
Show 20 quoted lines
> On Wed, Aug 12, 2015 at 5:57 PM, David Turner <dturner@twopensource.com> wrote: > > diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh > > index 93605f4..28e6dff 100755 > > --- a/t/t0060-path-utils.sh > > +++ b/t/t0060-path-utils.sh > > +test_expect_success 'handle per-worktree refs in refs/worktree' ' > > + git commit --allow-empty -m "initial commit" && > > + git worktree add -b branch worktree && > > + ( > > + cd worktree && > > + git commit --allow-empty -m "test commit" && > > + git for-each-ref | test_must_fail grep refs/worktree && > > s/test_must_fail/!/ > > From t/README: > > On the other hand, don't use test_must_fail for running regular > platform commands; just use '! cmd'. We are not in the business > of verifying that the world given to us sanely works.
When I make that change, my test fails with:
FATAL: Unexpected exit with code 2
Apparently, you can't use ! in pipelines like that. So that's why I used test_must_fail.