Re: [PATCH v3 1/4] refs: clean up common_list

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 15, 2015, 07:44 UTC
Message-ID: <CACsJy8CE8OA7AvT+BTPodRokX7qxAOkbY1UmR4qbtE8rUSoTqQ@mail.gmail.com>
In-Reply-To: <1439416645-19173-1-git-send-email-dturner@twopensource.com>

On Thu, Aug 13, 2015 at 4:57 AM, David Turner <dturner@twopensource.com> wrote:

Show 20 quoted lines

> +struct common_dir common_list[] = {
> +       { "branches", 0, 1, 0 },
> +       { "hooks", 0, 1, 0 },
> +       { "info", 0, 1, 0 },
> +       { "info/sparse-checkout", 0, 0, 1 },
> +       { "logs", 1, 1, 0 },
> +       { "logs/HEAD", 1, 1, 1 },
> +       { "lost-found", 0, 1, 0 },
> +       { "objects", 0, 1, 0 },
> +       { "refs", 0, 1, 0 },
> +       { "remotes", 0, 1, 0 },
> +       { "worktrees", 0, 1, 0 },
> +       { "rr-cache", 0, 1, 0 },
> +       { "svn", 0, 1, 0 },
> +       { "config", 0, 0, 0 },
> +       { "gc.pid", 1, 0, 0 },
> +       { "packed-refs", 0, 0, 0 },
> +       { "shallow", 0, 0, 0 },
> +       { NULL, 0, 0, 0 }
>  };

Nit. If you make dirname the last field, we would have aligned numbers, which might help reading.

-- 
Duy