Re: [PATCH v3 15/15] ref-filter: introduce objectname_atom_parser()

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 5, 2016, 21:31 UTC
Message-ID: <xmqqegdviugx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1451980994-26865-16-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 15 quoted lines

> @@ -467,15 +482,17 @@ static void *get_obj(const unsigned char *sha1, struct object **obj, unsigned lo
>  }
>  
>  static int grab_objectname(const char *name, const unsigned char *sha1,
> -			    struct atom_value *v)
> +			   struct atom_value *v, struct used_atom *atom)
>  {
> -	if (!strcmp(name, "objectname")) {
> -		v->s = xstrdup(sha1_to_hex(sha1));
> -		return 1;
> -	}
> -	if (!strcmp(name, "objectname:short")) {
> -		v->s = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
> -		return 1;
> +	if (starts_with(name, "objectname")) {

The original used to reject "objectnamefoo", but the updated one is more sloppy. Shouldn't it be doing the same match_atom_name() here?

This comment applies to many remaining strcmp() and starts_with() that is reachable from populate_value().