Re: [PATCH v3 04/15] ref-filter: introduce struct used_atom

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 21, 2016, 19:04 UTC
Message-ID: <CAPig+cSRDhbHmn5NSp_S4J99igFhBEpWfVMBKBDHCWAHN7-8qQ@mail.gmail.com>
In-Reply-To: <1451980994-26865-5-git-send-email-Karthik.188@gmail.com>

On Tuesday, January 5, 2016, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 15 quoted lines

> Introduce the 'used_atom' structure to replace the existing
> implementation of 'used_atom' (which is a list of atoms). This helps
> us parse atoms beforehand and store required details into the
> 'used_atom' for future usage.
>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
> ---
> diff --git a/ref-filter.c b/ref-filter.c
> @@ -17,7 +17,7 @@
>  typedef enum { FIELD_STR, FIELD_ULONG, FIELD_TIME } cmp_type;
>
>  /*
> - * An atom is a valid field atom listed above, possibly prefixed with
> + * An atom is a valid field atom listed below, possibly prefixed with

This particular change should be in patch 3/15 which moved this comment block.

(Yes, it's true that this will make the patch something other than "pure code movement", but this change keeps the moved block logically consistent and that it's an appropriate thing to do -- plus it's quite minor.)

>   * a "*" to denote deref_tag().
>   *
>   * We parse given format string and sort specifiers, and make a list